[ref:cargo-polishing] Cargo polishing #512

LordIdra · 2025-12-31T01:59:42Z

Add vanilla block compatibility to cargo extractor and inserter
Update all existing blocks to be logistics compatible
Abstract a lot of inserter/extractor logic out into a new interactor class (it was getting a bit much with the new logic for vanilla blocks)
Allow selecting the target inventory in extractors/inserters
Allow setting a filter (and blacklist/whitelist)
Adds a buffer to cargo extractor (but not inserter) - this is simpler for the filtering logic and drastically reduces the number of comparisons needed when moving items between e.g. two double chests

…er polishing

balugaq · 2026-01-02T13:37:30Z

Unable to transport Oak log into smelting slot (it can be both fuel and smelting)

Expected:

if item is fuel:
  if fuel slot if full:
    try transport to smelting slot.
  else:
    transport to fuel slot

balugaq · 2026-01-02T14:00:09Z

Unable to transport items into DecoratedPot

balugaq · 2026-01-02T14:02:09Z

QQ202612-215938.mp4

When transport items from containers, the redstone state didn't get updated.

balugaq · 2026-01-02T14:09:32Z

When transport into crafter, it ignored disabled slots

balugaq · 2026-01-02T14:22:31Z

When Cargo Extractor or Inserter was placed near the shulker box, the box couldn't be pushed by piston

balugaq · 2026-01-02T14:26:03Z

Unable to transport books into lectern

LordIdra · 2026-01-02T21:29:41Z

Unable to transport books into lectern

Intentional, not supported

Unable to transport items into DecoratedPot

Intentional, not supported

LordIdra · 2026-01-02T21:47:41Z

Unable to transport `Oak log` into smelting slot (`it can be both fuel and smelting`)
Expected:
if item is fuel:
  if fuel slot if full:
    try transport to smelting slot.
  else:
    transport to fuel slot

Unable to reproduce. This might be an issue with cargo routing, there are several fixes in subsequent PRs.

LordIdra · 2026-01-02T21:50:32Z

QQ202612-215938.mp4
When transport items from containers, the redstone state didn't get updated.

Unable to play the video but I think you're using a chiselled bookshelf there to test? Chiselled bookshelves are a bit screwed atm because of paper, not because of pylon, so not surprised that this is an issue. I have tested with other containers and redstone state updates just fine

LordIdra · 2026-01-02T21:54:44Z

When transport into crafter, it ignored `disabled slots`

This is a really unfortunate issue which is extremely hard to fix with the system as it's set up. I'm going to leave this and open an issue instead because I need to think on it and I'm not sure how to fix it yet

LordIdra · 2026-01-02T22:00:12Z

When Cargo Extractor or Inserter was placed near the shulker box, the box couldn't be pushed by piston

This is intended behaviour because of how the multiblock system works; it can't handle multiblock components being pushed around by pistons

balugaq · 2026-01-03T02:53:57Z

QQ202612-215938.mp4
When transport items from containers, the redstone state didn't get updated.

Unable to play the video but I think you're using a chiselled bookshelf there to test? Chiselled bookshelves are a bit screwed atm because of paper, not because of pylon, so not surprised that this is an issue. I have tested with other containers and redstone state updates just fine

Also tested hopper

Expected:
if item is fuel:
  if fuel slot if full:
    try transport to smelting slot.
  else:
    transport to fuel slot
Unable to reproduce. This might be an issue with cargo routing, there are several fixes in subsequent PRs.

This comment I changed yesterday but didn't change probably due to lag.
So when I find this bug, I didn't find the cycle button. Because the first time I see the cycle button, there's no any cycle text on it. I didn't think it has some special features. This feature is somewhat a bit hidden for me.

LordIdra · 2026-01-04T13:43:09Z

Also tested hopper

Confirmed. That's really weird. I think this will need manual state access in the same way as the crafter issue will require... I don't see an easy way to fix this and it's niche enough that I'll just open an issue for now and come back to it later

Seggan · 2026-01-06T00:38:41Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/cargo/CargoInserter.java

-                addCargoLogisticGroup(face, targetLogisticGroup);
-            }
+            // Slight hack: Set the logistic group to 'none' (which should not exist)
+            addCargoLogisticGroup(face, targetLogisticGroup == null ? "none" : targetLogisticGroup);


To be safe you can just use the empty string, but this is a nit

Seggan · 2026-01-06T00:40:59Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/cargo/CargoInteractor.java

+        if (!targetGroups.containsKey(targetLogisticGroup)) {
+            setTargetLogisticGroup(null);
+        }
+
+        // Find new logistic group if group does not exist
+        if (targetLogisticGroup == null) {


In the case where the group does not exist but is nonnull it won't automatically find a new one

Seggan · 2026-01-06T00:44:30Z

src/main/java/io/github/pylonmc/pylon/base/content/machines/hydraulics/HydraulicBreaker.java


+    @Override
+    public @NotNull Gui createGui() {
+        // Not actually used, just provided for easy inventory serialization


Umm you can serialize inventories without a gui you know that right

keyword 'easy' (and virtual inv serializer was not in at the time) - but it doesn't matter regardless since inventory serialization will be changed

LordIdra and others added 6 commits December 29, 2025 22:04

sync

4961998

wtf

45559e1

Allow for interacting with vanilla inventory + cargo extractor/insert…

7d52c5a

…er polishing

Move logistic slots to their own package

ef6df7e

Rename LogisticSlotType to LogisticGroupType

aaf6824

Convert all inventory blocks to be logistics compatible

dfddbe5

LordIdra mentioned this pull request Jan 2, 2026

Inserters ignore disabled slots in crafter #519

Open

Move util function to LogisticGroup

7d33ce6

Seggan requested changes Jan 6, 2026

View reviewed changes

Base automatically changed from more-cargo-blocks to master January 9, 2026 02:36

Merge branch 'master' into cargo-polishing

f2eaad6

LordIdra merged commit 3cc9311 into master Jan 9, 2026
1 check failed

LordIdra deleted the cargo-polishing branch January 9, 2026 02:50

[ref:cargo-polishing] Cargo polishing #512

[ref:cargo-polishing] Cargo polishing #512

Uh oh!

Conversation

LordIdra commented Dec 31, 2025

Uh oh!

balugaq commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balugaq commented Jan 2, 2026

Uh oh!

balugaq commented Jan 2, 2026

Uh oh!

balugaq commented Jan 2, 2026

Uh oh!

balugaq commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balugaq commented Jan 2, 2026

Uh oh!

LordIdra commented Jan 2, 2026

Uh oh!

LordIdra commented Jan 2, 2026

Uh oh!

LordIdra commented Jan 2, 2026

Uh oh!

LordIdra commented Jan 2, 2026

Uh oh!

LordIdra commented Jan 2, 2026

Uh oh!

balugaq commented Jan 3, 2026

Uh oh!

LordIdra commented Jan 4, 2026

Uh oh!

Seggan Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Seggan Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Seggan Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

LordIdra Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

balugaq commented Jan 2, 2026 •

edited

Loading

balugaq commented Jan 2, 2026 •

edited

Loading